linux-kernel - Re: [PATCH 4/4] staging: rtl8188eu/rtl8723bs: fix character encoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180724115532.GA18156@kroah.com>
Date:   Tue, 24 Jul 2018 13:55:32 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Joe Perches <joe@...ches.com>,
        Aastha Gupta <aastha.gupta4104@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] staging: rtl8188eu/rtl8723bs: fix character encoding

On Tue, Jul 24, 2018 at 01:53:17PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jul 24, 2018 at 01:13:28PM +0200, Arnd Bergmann wrote:
> > drivers/staging/rtl8188eu/include/odm.h uses an incorrect encoding
> > for the '...' character in two comments, which makes it one of the
> > few non-UTF-8 source files.
> > 
> > This removes the odd characters and uses the same ASCII representation
> > that we have in the regular rtlwifi driver. The second instance
> > of drivers/staging/rtl8723bs/hal/odm.h is garbled in a different way,
> > so I change it to be the same as well even though it is already
> > plain ASCII.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> 
> git does not like this patch:
> 	error: cannot convert from Binary to UTF-8
> 	fatal: could not parse patch
> Let me see if I can force it by hand...
> 

Had to remove the "Binary" marking on the email and then it worked.
Odd...

greg k-h