linux-kernel - Re: [PATCH 2/2] media: i2c: Add driver for Aptina MT9V111

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Jul 2018 16:23:51 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     jacopo mondi <jacopo@...ndi.org>
Cc:     Jacopo Mondi <jacopo+renesas@...ndi.org>, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 2/2] media: i2c: Add driver for Aptina MT9V111

Hi Jacopo,

On Tue, Jul 24, 2018 at 03:08:45PM +0200, jacopo mondi wrote:
> > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > > index 341452f..0bd867d 100644
> > > --- a/drivers/media/i2c/Kconfig
> > > +++ b/drivers/media/i2c/Kconfig
> > > @@ -841,6 +841,18 @@ config VIDEO_MT9V032
> > >  	  This is a Video4Linux2 sensor-level driver for the Micron
> > >  	  MT9V032 752x480 CMOS sensor.
> > >
> > > +config VIDEO_MT9V111
> > > +	tristate "Aptina MT9V111 sensor support"
> > > +	depends on I2C && VIDEO_V4L2
> > > +	depends on MEDIA_CAMERA_SUPPORT
> > > +	depends on OF
> >
> > Why OF? I see no effective OF dependencies in the driver.
> >
> 
> Isn't the driver probing through OF?

It may, but the driver is otherwise not technically limited to OF. ACPI
could be used as well, for instance.

> 
> > > +	help
> > > +	  This is a Video4Linux2 sensor-level driver for the Aptina/Micron
> 
> I'll change sensor-level to sensor, has you've been doing lately on
> all other Kconfig entries

Ack.

-- 
Sakari Ailus
e-mail: sakari.ailus@....fi