linux-kernel - Re: [PATCH 1/2] sparc: move MSI related definitions to where they are used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180724143736.GA22088@ravnborg.org>
Date:   Tue, 24 Jul 2018 16:37:36 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
        Marc Zyngier <marc.zyngier@....com>,
        Hanna Hawa <hannah@...vell.com>
Subject: Re: [PATCH 1/2] sparc: move MSI related definitions to where they
 are used

Hi Thomas.

One nitpick below.
But other than that this is a nice cleanup:
Acked-by: Sam Ravnborg <sam@...nborg.org>
> +/*
> + * Locations of MSI Registers.
> + */

The SPARC way to format comments follows netdev style.
So put it all in one line and everyone are happy:

    /* Locations of MSI Registers. */

> +#define MSI_MBUS_ARBEN	0xe0001008	/* MBus Arbiter Enable register */
> +
> +/*
> + * Useful bits in the MSI Registers.
> + */
Likewise

	Sam