linux-kernel - Re: [PATCH 1/2] sparc: move MSI related definitions to where they are used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180724145525.GA14300@ravnborg.org>
Date:   Tue, 24 Jul 2018 16:55:25 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
        Marc Zyngier <marc.zyngier@....com>,
        Hanna Hawa <hannah@...vell.com>
Subject: Re: [PATCH 1/2] sparc: move MSI related definitions to where they
 are used

Hi Thomas.

> > 
> > The SPARC way to format comments follows netdev style.
> > So put it all in one line and everyone are happy:
> 
> Well, the code is being moved from arch/sparc to arch/sparc, so
> apparently, it was already non-compliant to this specific coding style
> rule. Should the comments be made compliant as part of the same commit,
> or a separate one ?
Same commit, no reason to slit this in two.
So post a v2, then everyone should be happy.

I also looked at the second patch which looked obviously correct.
Feel free to add my Ack on both.

	Sam