linux-kernel - Re: [PATCH] vxge: Remove unnecessary include of <linux/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180724154526.GB5871@kudzu.us>
Date:   Tue, 24 Jul 2018 11:45:27 -0400
From:   Jon Mason <jdmason@...zu.us>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vxge: Remove unnecessary include of <linux/pci_hotplug.h>

On Mon, Jul 23, 2018 at 03:59:46PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> The vxge driver doesn't need anything provided by pci_hotplug.h, so remove
> the unnecessary include of it.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Not sure you need my ack for something so trivial, but here it is
Acked-by: Jon Mason <jdmason@...zu.us>

> ---
>  drivers/net/ethernet/neterion/vxge/vxge-config.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c
> index 358ed6118881..a2c0a93ca8b6 100644
> --- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
> +++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
> @@ -14,7 +14,6 @@
>  #include <linux/vmalloc.h>
>  #include <linux/etherdevice.h>
>  #include <linux/pci.h>
> -#include <linux/pci_hotplug.h>
>  #include <linux/slab.h>
>  
>  #include "vxge-traffic.h"
>