linux-kernel - Re: [PATCH 18/18] cpupower: change strncpy+truncation to strlcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d421d32-ab85-1d4e-0aaf-7f221e0110b0@kernel.org>
Date:   Tue, 24 Jul 2018 10:31:15 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Dominique Martinet <asmadeus@...ewreck.org>
Cc:     Thomas Renninger <trenn@...e.com>,
        Colin Ian King <colin.king@...onical.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH 18/18] cpupower: change strncpy+truncation to strlcpy

On 07/12/2018 07:26 PM, Dominique Martinet wrote:
> Generated by scripts/coccinelle/misc/strncpy_truncation.cocci
> 
> Signed-off-by: Dominique Martinet <asmadeus@...ewreck.org>
> ---
> 
> Please see https://marc.info/?l=linux-kernel&m=153144450722324&w=2 (the
> first patch of the serie) for the motivation behind this patch
> 
>  tools/power/cpupower/bench/parse.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/power/cpupower/bench/parse.c b/tools/power/cpupower/bench/parse.c
> index 9ba8a44ad2a7..1566b89989b2 100644
> --- a/tools/power/cpupower/bench/parse.c
> +++ b/tools/power/cpupower/bench/parse.c
> @@ -221,9 +221,8 @@ int prepare_config(const char *path, struct config *config)
>  			sscanf(val, "%u", &config->cpu);
>  
>  		else if (strcmp("governor", opt) == 0) {
> -			strncpy(config->governor, val,
> +			strlcpy(config->governor, val,
>  					sizeof(config->governor));
> -			config->governor[sizeof(config->governor) - 1] = '\0';
>  		}
>  
>  		else if (strcmp("priority", opt) == 0) {
> 

Thanks for the patch. I will pull this in for 4.19-rc1

-- Shuah