linux-kernel - Re: [PATCH] usb: usbip: remove redundant pointer ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Jul 2018 10:42:33 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Colin King <colin.king@...onical.com>,
        Valentina Manea <valentina.manea.m@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] usb: usbip: remove redundant pointer ep

On 07/13/2018 04:45 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointer ep is being assigned but is never used hence it is
> redundant and can be removed.
> 
> Cleans up clang warning:
> warning: variable 'ep' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/usb/usbip/vudc_dev.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
> index 1b9a4f87db59..1634d8698e15 100644
> --- a/drivers/usb/usbip/vudc_dev.c
> +++ b/drivers/usb/usbip/vudc_dev.c
> @@ -279,12 +279,10 @@ static int vep_disable(struct usb_ep *_ep)
>  static struct usb_request *vep_alloc_request(struct usb_ep *_ep,
>  		gfp_t mem_flags)
>  {
> -	struct vep *ep;
>  	struct vrequest *req;
>  
>  	if (!_ep)
>  		return NULL;
> -	ep = to_vep(_ep);
>  
>  	req = kzalloc(sizeof(*req), mem_flags);
>  	if (!req)
> 

Thanks for the patch. Looks good to me.

Acked-by: Shuah Khan (Samsung OSG) <shuah@...nel.org>

thanks,
-- Shuah