linux-kernel - Re: [PATCH v2] ASoC: da7219: Allow pdata to specify a VDDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Jul 2018 17:58:35 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Cc:     Daniel Kurtz <djkurtz@...omium.org>,
        Akshu Agrawal <akshu.agrawal@....com>,
        Support Opensource <Support.Opensource@...semi.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        "moderated list:SOUND" <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ASoC: da7219: Allow pdata to specify a VDDIO

On Mon, Jul 23, 2018 at 02:41:26PM +0000, Adam Thomson wrote:
> On 23 July 2018 00:28, Daniel Kurtz wrote:

> > Provide a new device property to let such systems specify a different
> > VDDIO if needed (e.g., 1.8V).

> I'm not sure what the general view on this is. In the past it was suggested
> the regulator framework was the way to go to pass this kind of information,
> but obviously ACPI platforms don't tend to use it.

> Mark, what is your feeling on this? Would you be in favour of some kind of 
> fixed voltage regulator representation, similar to the patch for the AMD
> platform (ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002),
> albeit tweaked to avoid asynchronous probe() issues, or is this a reasonable
> route? Personally in my mind, and in an ideal world, I'd prefer just one method
> for retrieving this data in the codec driver, but that may not be sensible.

Yeah, keeping things consistent if we can seems like a definite win
which points towards using regulators here.  One other thing that
concerns me with using device properties here is what exactly we'd be
expecting to set them - I'd not expect system integrators to suddenly
start adding such properties.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)