linux-kernel - Re: [PATCH] mips: use asm-generic version of msi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180724173637.2y2cdpqean6t3vso@pburton-laptop>
Date:   Tue, 24 Jul 2018 10:36:37 -0700
From:   Paul Burton <paul.burton@...s.com>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Cc:     Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org, Marc Zyngier <marc.zyngier@....com>,
        Hanna Hawa <hannah@...vell.com>
Subject: Re: [PATCH] mips: use asm-generic version of msi.h

Hi Thomas,

On Tue, Jul 24, 2018 at 01:52:08PM +0200, Thomas Petazzoni wrote:
> This is necessary to be able to include <linux/msi.h> when
> CONFIG_GENERIC_MSI_IRQ_DOMAIN is enabled. Without this, a build with
> CONFIG_GENERIC_MSI_IRQ_DOMAIN fails with:
> 
>    In file included from include/linux/kvm_host.h:20:0,
>                     from arch/mips/kernel/asm-offsets.c:24:
> >> include/linux/msi.h:197:10: fatal error: asm/msi.h: No such file or directory
>     #include <asm/msi.h>
>              ^~~~~~~~~~~
>    compilation terminated.
>    make[2]: *** [arch/mips/kernel/asm-offsets.s] Error 1
>    make[2]: Target '__build' not remade because of errors.
>    make[1]: *** [prepare0] Error 2
>    make[1]: Target 'prepare' not remade because of errors.
>    make: *** [sub-make] Error 2
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...tlin.com>
> ---
>  arch/mips/include/asm/Kbuild | 1 +
>  1 file changed, 1 insertion(+)

Thanks, applied to mips-next for 4.19.

BTW it looks like a bunch of other architectures might need this too - a
grep suggests more architectures lack asm/msi.h (17) than have it.

Paul