linux-kernel - Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyV=5QNJXn+t_ZDCigGi+HjM6N94DRb_E50_xUsk+VTFA@mail.gmail.com>
Date:   Tue, 24 Jul 2018 10:37:56 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     mchehab+samsung@...nel.org
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        Staging subsystem List <devel@...verdev.osuosl.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after
 generic includes

On Mon, Jul 23, 2018 at 8:41 PM Mauro Carvalho Chehab
<mchehab+samsung@...nel.org> wrote:
>
> While I won't be against merging it, IMHO a better fix would be to
> add the includes asm/cacheflush.h needs inside it, e. g. something
> like adding:

No. The <asm/*> includes really should come after <linux/*>.

This is a media driver bug, plain and simple.

We should strive to avoid adding more header includes, it's one of the
major causes of kernel build slowdown.

             Linus