linux-kernel - Re: [PATCH v6 1/9] Makefile: Prepare for using macros for inline asm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A1E263C1-C1DA-4B23-8232-8CF87DDD7A3F@vmware.com>
Date:   Tue, 24 Jul 2018 18:04:06 +0000
From:   Nadav Amit <namit@...are.com>
To:     Ingo Molnar <mingo@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        X86 ML <x86@...nel.org>, Sam Ravnborg <sam@...nborg.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        "linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>
Subject: Re: [PATCH v6 1/9] Makefile: Prepare for using macros for inline asm

at 4:14 AM, Ingo Molnar <mingo@...nel.org> wrote:

> 
> * Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
> 
>> 2018-06-23 2:22 GMT+09:00 Nadav Amit <namit@...are.com>:
>>> Using macros for inline assembly improves both readability and
>>> compilation decisions that are distorted by big assembly blocks that use
>>> alternative sections. Compile macros.S and use it to assemble all C
>>> files. Currently, only x86 will use it.
>>> 
>>> Cc: Sam Ravnborg <sam@...nborg.org>
>>> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>> Cc: Michal Marek <michal.lkml@...kovi.net>
>>> Cc: Thomas Gleixner <tglx@...utronix.de>
>>> Cc: Ingo Molnar <mingo@...hat.com>
>>> Cc: "H. Peter Anvin" <hpa@...or.com>
>>> Cc: x86@...nel.org
>>> Cc: linux-kbuild@...r.kernel.org
>>> Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>
>>> Signed-off-by: Nadav Amit <namit@...are.com>
>>> ---
>> 
>> 
>> 
>> Acked-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>> 
>> 
>> 
>> 
>>> Makefile                 |  9 +++++++--
>>> arch/x86/Makefile        | 11 +++++++++--
>>> arch/x86/kernel/macros.S |  7 +++++++
>>> scripts/Kbuild.include   |  4 +++-
>>> scripts/mod/Makefile     |  2 ++
>>> 5 files changed, 28 insertions(+), 5 deletions(-)
>>> create mode 100644 arch/x86/kernel/macros.S
> 
> So this patch appears to break the xtensa cross-build on my system, with an older 
> version of crosstools:
> 
>  MODPOST vmlinux.o
> /home/mingo/crosstool-korg/bin//gcc-4.9.0-nolibc/xtensa-linux/bin/xtensa-linux-ld:./arch/xtensa/kernel/vmlinux.lds:430: 
> syntax error
> /home/mingo/tip/Makefile:1010: recipe for target 'vmlinux' failed
> make[1]: *** [vmlinux] Error 1
> make[1]: Leaving directory '/dev/shm/tip/build'
> Makefile:146: recipe for target 'sub-make’ failed

This one is due to a missing -DLINKER_SCRIPT in the Makefile of xtensa. I’ll
send the patch to fix it after I deal with the boot failure (for which I
wait for your config file).

Thanks,
Nadav