linux-kernel - Re: [PATCH] delayacct: Fix crash in delayacct_blkio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180724122913.af508cf58033e9b1147e7def@linux-foundation.org>
Date:   Tue, 24 Jul 2018 12:29:13 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Tejun Heo <tj@...nel.org>
Cc:     Balbir Singh <bsingharora@...il.com>, linux-kernel@...r.kernel.org,
        kernel-team@...com
Subject: Re: [PATCH] delayacct: Fix crash in delayacct_blkio_end() after
 delayacct init failure

On Tue, 24 Jul 2018 10:55:42 -0700 Tejun Heo <tj@...nel.org> wrote:

> While forking, if delayacct init fails due to memory shortage, it
> continues expecting all delayacct users to check task->delays pointer
> against NULL before dereferencing it, which all of them used to do.
> 
> c96f5471ce7d ("delayacct: Account blkio completion on the correct
> task"), while updating delayacct_blkio_end() to take the target task
> instead of always using %current, made the function test NULL on
> %current->delays and then continue to operated on @p->delays.  If
> %current succeeded init while @p didn't, it leads to the following
> crash.
> 

lgtm.

How did you make this happen, btw?  Fault injection, or did a small
GFP_KERNEL allocation fail?