linux-kernel - Re: [PATCH] libnvdimm: fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Jul 2018 13:46:29 -0600
From:   Keith Busch <keith.busch@...el.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Ross Zwisler <zwisler@...nel.org>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Dave Jiang <dave.jiang@...el.com>, linux-nvdimm@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libnvdimm: fix NULL pointer dereference

On Tue, Jul 24, 2018 at 08:40:06AM -0500, Gustavo A. R. Silva wrote:
> ndd is being dereferenced before it is null checked, hence there is a
> potential null pointer dereference.
> 
> Fix this by moving the pointer dereference after ndd has been properly
> null checked at line 554: if (!ndd)

I'll fold this into v4 of the patch since Vishal found an issue when a
DIMM has multiple regions.