linux-kernel - Re: [PATCH v5 3/3] arm64: dts: qcom: pm8998: Add pm8998 thermal zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Jul 2018 16:21:28 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>, devicetree@...r.kernel.org,
        linux-pm@...r.kernel.org, David Collins <collinsd@...eaurora.org>,
        Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH v5 3/3] arm64: dts: qcom: pm8998: Add pm8998 thermal zone

Hi,

On Tue, Jul 24, 2018 at 4:46 PM, Matthias Kaehlcke <mka@...omium.org> wrote:
> The thermal zone uses spmi-temp-alarm as sensor, the trip points
> correspond to the PMIC thermal stages 1 and 2. The critical trip
> point at 125°C disables the partial PMIC shutdown at stage 2.
>
> Without an IIO input the sensor only reports a limited number of
> temperatures:
>
> - 37°C for temperatures below 105°C
> - 107°C for temperatures >= 105°C and < 125°C
> - 127°C for temperatures >= 125°C
>
> (the numbers correspond to a stage 1 threshold of 105°C)
>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
> Changes in v5:
> - removed 'stage2-shutdown-disabled' property from spmi-temp-alarm
> - updated commit message
>
> Changes in v4:
> - updated trip point temperatures to match stage 1 and 2 ones
> - disabled stage 2 shutdown
> - updated commit message
>
> Changes in v3:
> - moved 'thermal-zones' node to the beginning of the .dtsi
>
> Changes in v2:
> - defined 'thermal-zones' node in pm8998.dtsi instead of using a label
>   to refer to it
> - use 105°C hardware trip point as critical trip point
> - reduced number of trip points to 2
> - lowered temperature of passive trip point
> - updated trip point names and added labels
> - updated commit message
> ---
>  arch/arm64/boot/dts/qcom/pm8998.dtsi | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)

Looks great!

Reviewed-by: Douglas Anderson <dianders@...omium.org>