linux-kernel - Re: [PATCH] clk: tegra: probe deferral error reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <153256109511.48062.12389268791907553857@swboyd.mtv.corp.google.com>
Date:   Wed, 25 Jul 2018 16:24:55 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Marcel Ziswiler <marcel@...wiler.com>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Cc:     Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: tegra: probe deferral error reporting

Quoting Marcel Ziswiler (2018-07-20 00:54:22)
> From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> Actually report the error code from devm_regulator_get() which may as
> well just be a probe deferral.
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> ---
> 
>  drivers/clk/tegra/clk-dfll.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
> index 48ee43734e05..b2123084e175 100644
> --- a/drivers/clk/tegra/clk-dfll.c
> +++ b/drivers/clk/tegra/clk-dfll.c
> @@ -1609,8 +1609,9 @@ int tegra_dfll_register(struct platform_device *pdev,
>  
>         td->vdd_reg = devm_regulator_get(td->dev, "vdd-cpu");
>         if (IS_ERR(td->vdd_reg)) {
> -               dev_err(td->dev, "couldn't get vdd_cpu regulator\n");
> -               return PTR_ERR(td->vdd_reg);
> +               ret = PTR_ERR(td->vdd_reg);
> +               dev_err(td->dev, "couldn't get vdd_cpu regulator: %d\n", ret);

Do you want to know that a probe defer is happening? Usually patches are
sent to make that error path silent.