linux-kernel - Re: [PATCH] KVM/MMU: Combine flushing remote tlb in mmu_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56751e17-a271-1a73-026b-838e6b739420@gmail.com>
Date:   Wed, 25 Jul 2018 14:22:54 +0800
From:   Xiao Guangrong <xiaoguangrong.eric@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        Tianyu Lan <Tianyu.Lan@...rosoft.com>
Cc:     "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Xiao Guangrong <guangrong.xiao@...ux.intel.com>,
        Junaid Shahid <junaids@...gle.com>
Subject: Re: [PATCH] KVM/MMU: Combine flushing remote tlb in mmu_set_spte()



On 07/24/2018 10:35 PM, Paolo Bonzini wrote:
> On 24/07/2018 10:17, Tianyu Lan wrote:
>> mmu_set_spte() flushes remote tlbs for drop_parent_pte/drop_spte()
>> and set_spte() separately. This may introduce redundant flush. This
>> patch is to combine these flushes and check flush request after
>> calling set_spte().
>>
>> Signed-off-by: Lan Tianyu <Tianyu.Lan@...rosoft.com>
> 
> Looks good, but I'd like a second opinion.  Guangrong, Junaid, can you
> review this?
> 

It looks good to me.

Reviewed-by: Xiao Guangrong <xiaoguangrong@...cent.com>

BTW, the @intel box is not accessible to me now. ;)