linux-kernel - Re: [PATCH 20/32] ARM: dts: omap3-gta04: add devconf0 setup for mcbsp1 clock pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Jul 2018 10:19:44 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Ladislav Michl <ladis@...ux-mips.org>
Cc:     Marek Belisko <marek@...delico.com>,
        Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH 20/32] ARM: dts: omap3-gta04: add devconf0 setup for mcbsp1 clock pins


> Am 25.07.2018 um 10:12 schrieb Ladislav Michl <ladis@...ux-mips.org>:
> 
> On Wed, Jul 25, 2018 at 08:58:52AM +0200, H. Nikolaus Schaller wrote:
>> McBSP1 needs sepcial "pinctrl" for the clocks.
> 
> Nit: "special" perhaps?

Thanks! Seems to be missing in the spell checker of checkpatch (or I didn't notice the message).

BR,
Nikolaus

> 
>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>> ---
>> arch/arm/boot/dts/omap3-gta04.dtsi | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
>> index 935a2a707737..f6abdef556c1 100644
>> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
>> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
>> @@ -187,6 +187,24 @@
>> 		reset-gpios = <&tca6507 0 GPIO_ACTIVE_LOW>;	/* W2CBW003 reset through tca6507 */
>> 	};
>> 
>> +	/* devconf0 setup for mcbsp1 clock pins */
>> +	pinmux_mcbsp1@...02274 {
>> +		compatible = "pinctrl-single";
>> +		reg = <0x48002274 4>;   /* CONTROL_DEVCONF0 */
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +		pinctrl-single,bit-per-mux;
>> +		pinctrl-single,register-width = <32>;
>> +		pinctrl-single,function-mask = <0x7>;	/* MCBSP1 CLK pinmux */
>> +		#pinctrl-cells = <2>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&mcbsp1_devconf0_pins>;
>> +		mcbsp1_devconf0_pins: pinmux_mcbsp1_devconf0_pins {
>> +			/*                   offset bits mask */
>> +			pinctrl-single,bits = <0x00 0x08 0x1c>;	/* set MCBSP1_CLKR */
>> +		};
>> +	};
>> +
>> 	/* devconf1 setup for tvout pins */
>> 	pinmux_tv_out@...022d8 {
>> 		compatible = "pinctrl-single";
>> -- 
>> 2.12.2
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html