linux-kernel - RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY1PR02MB16921C8D66930128BAF104B4DC540@CY1PR02MB1692.namprd02.prod.outlook.com>
Date:   Wed, 25 Jul 2018 09:13:57 +0000
From:   Appana Durga Kedareswara Rao <appanad@...inx.com>
To:     Alan Tull <atull@...nel.org>
CC:     Moritz Fischer <mdf@...nel.org>,
        Nava kishore Manne <navam@...inx.com>,
        Michal Simek <michals@...inx.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

Hi Alan,

	Thanks for the review...

<Snip> 
> Another minor thing.
> 
> > +
> >
> +/**************************************************************
> ******
> > +********/
> 
> Let's keep the coding style consistent by not having

Sure will fix in v4...

> '***************************'
> 
> > +/**
> > + *
> 
> Also, you don't need /** followed by '*', just take out the essentially blank
> line here, please.

Sure will fix in v4...

Regards,
Kedar.

> 
> > + * Generates a Type 2 packet header that reads back the requested
> > +Configuration
> > + * register.
> > + *
> > + * @param        OpCode is the read/write operation code.
> > + * @param        Size is the size of the word to be read.
> > + *
> > + * @return       Type 2 packet header to read the specified register
> > + *
> > + * @note         None.
> > + *
> > +
> >
> +***************************************************************
> ******
> > +********/ static int zynq_type2_pkt(u8 OpCode, u32 Size) {
> 
> Thanks,
> Alan