linux-kernel - Re: [PATCH 1/1] dmaengine: mv_xor_v2: use {lower,upper}_32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180725121712.GP3661@vkoul-mobl>
Date:   Wed, 25 Jul 2018 17:47:12 +0530
From:   Vinod <vkoul@...nel.org>
To:     hannah@...vell.com
Cc:     dan.j.williams@...el.com, dmaengine@...r.kernel.org,
        thomas.petazzoni@...tlin.com, linux-kernel@...r.kernel.org,
        nadavh@...vell.com, omrii@...vell.com, oferh@...vell.com,
        gregory.clement@...tlin.com
Subject: Re: [PATCH 1/1] dmaengine: mv_xor_v2: use {lower,upper}_32_bits to
 configure HW descriptor address

On 24-07-18, 16:40, hannah@...vell.com wrote:
> From: Hanna Hawa <hannah@...vell.com>
> 
> >> drivers/dma/mv_xor_v2.c:647:36: sparse: constant 0xFFFF00000000 is so big it is long
>    include/linux/device.h:678:13: sparse: undefined identifier '__builtin_mul_overflow'
>    include/linux/device.h:678:13: sparse: call with no type!
> 
> Use lower_32_bits and upper_32_bits to set the hw_desq address, instead of
> using constant.

Applied after adding reported-by, thanks.

You should always give credit to error reports

-- 
~Vinod