linux-kernel - Re: [PATCH 04/32] ARM: dts: omap3-gta04: fixes for tvout / venc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7FAC0538-D5AE-4DCF-9036-DAD881E957C5@goldelico.com>
Date:   Wed, 25 Jul 2018 14:31:48 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Tomi Valkeinen <tomi.valkeinen@...com>
Cc:     Marek Belisko <marek@...delico.com>,
        Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-omap <linux-omap@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>
Subject: Re: [PATCH 04/32] ARM: dts: omap3-gta04: fixes for tvout / venc

Hi Sebastian,

> Am 25.07.2018 um 12:37 schrieb Sebastian Reichel <sebastian.reichel@...labora.co.uk>:
> 
> Hi,
> 
> On Wed, Jul 25, 2018 at 08:58:36AM +0200, H. Nikolaus Schaller wrote:
>> 			port@1 {
>> -				reg = <1>;
>> +				reg = <0>;
> 
> You should also update the node name.

I did take another look at this and we might have the wrong fix here anyways.
The first indication is that a port@0 already exists soI can't simply rename
the node.

The opa362 is an exceptional dssdev since it has an input and an output port
which should be differentiated by the reg property and the node name.

Ports are apparently matched by reg number, i.e. here:

	https://elixir.bootlin.com/linux/v4.18-rc6/source/drivers/gpu/drm/omapdrm/dss/output.c#L146

The issue seems to be that the driver does not set the out->port_num of the endpoint to 1.

	https://elixir.bootlin.com/linux/v4.18-rc6/source/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c#L205

So the <1> does not match and we were just lucky to make it working by choosing <0> in the DT.

I'll need a little time to test if a (one-liner) patch for the driver does the same/right thing.

And since it is omapdss related I've put Tomi on CC:

BR,
Nikolaus

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)