linux-kernel - Re: [linux-sunxi] [PATCH v3 6/9] dt-bindings: phy: add binding for Allwinner USB3 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180725153126.GA8350@rob-hp-laptop>
Date:   Wed, 25 Jul 2018 09:31:26 -0600
From:   Rob Herring <robh@...nel.org>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     Icenowy Zheng <icenowy@...c.io>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [linux-sunxi] [PATCH v3 6/9] dt-bindings: phy: add binding for
 Allwinner USB3 PHY

On Sun, Jul 22, 2018 at 02:10:33PM +0800, Chen-Yu Tsai wrote:
> On Sun, Jul 22, 2018 at 1:57 PM, Icenowy Zheng <icenowy@...c.io> wrote:
> > The new Allwinner H6 SoC contains a USB3 PHY that is wired to the
> > external USB3 pins of the SoC.
> >
> > Add a device tree binding for the PHY.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@...c.io>
> > Reviewed-by: Chen-Yu Tsai <wens@...e.org>
> > ---
> > Changes in v3:
> > - Added Chen-Yu's Review tag.
> >
> > Rob,
> > Although you mentioned that the supply is for the port, not the phy;
> > currently in USB situation "powering on the PHY" also indicates
> > "powering on the port" and nearly all usages of phy-supply is for Vbus.
> >
> > Maybe we should change the overall phy-supply to satisfy this.
> 
> Or maybe change it to vbus-supply, like we have for phy-sun4i-usb,
> until USB port power sequencing is added. (I remember there were
> patches for this. What happened?)

Once it is in the binding, we are stuck with it.

Connector bindings have landed. We should add vbus-supply to that. You 
don't have to have a property in the node associated with a driver. The 
phy driver can walk the tree and get the Vbus supply.

UniPhier has the same issue.

Rob