linux-kernel - Re: [PATCH v2] tracing/kprobes: Fix trace_probe flags on enable_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180725114234.5b8b7860@gandalf.local.home>
Date:   Wed, 25 Jul 2018 11:42:34 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Artem Savkov <asavkov@...hat.com>, Ingo Molnar <mingo@...hat.com>,
        linux-kernel@...r.kernel.org, Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [PATCH v2] tracing/kprobes: Fix trace_probe flags on
 enable_trace_kprobe() failure

On Thu, 26 Jul 2018 00:41:13 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> On Wed, 25 Jul 2018 16:20:38 +0200
> Artem Savkov <asavkov@...hat.com> wrote:
> 
> > If enable_trace_kprobe fails to enable the probe in enable_k(ret)probe
> > it returns an error, but does not unset the tp flags it set previously.
> > This results in a probe being considered enabled and failures like being
> > unable to remove the probe through kprobe_events file since probes_open()
> > expects every probe to be disabled.
> >   
> 
> Looks good to me.
> 
> Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks Masami,

-- Steve