linux-kernel - RE: [PATCH 4/8] usb: dwc3: implement stream transfer timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR02MB2816411003B8BB7D3B041587A7540@MWHPR02MB2816.namprd02.prod.outlook.com>
Date:   Wed, 25 Jul 2018 15:51:14 +0000
From:   Anurag Kumar Vulisha <anuragku@...inx.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "v.anuragkumar@...il.com" <v.anuragkumar@...il.com>,
        USB <linux-usb@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 4/8] usb: dwc3: implement stream transfer timeout



>-----Original Message-----
>From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
>Sent: Wednesday, July 25, 2018 8:55 PM
>To: Anurag Kumar Vulisha <anuragku@...inx.com>
>Cc: Felipe Balbi <balbi@...nel.org>; Greg Kroah-Hartman
><gregkh@...uxfoundation.org>; v.anuragkumar@...il.com; USB <linux-
>usb@...r.kernel.org>; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
>Subject: Re: [PATCH 4/8] usb: dwc3: implement stream transfer timeout
>
>On Wed, Jul 25, 2018 at 6:14 PM, Anurag Kumar Vulisha
><anuragku@...inx.com> wrote:
>
>>>> +/*
>>>> + * Timeout value in msecs used by stream_timeout_timer when streams
>>>> +are enabled  */
>>>> +#define STREAM_TIMEOUT         50
>>>
>>>Perhaps, STREAM_TIMEOUT_MS 50
>>>
>>>Dunno about this driver, but it's a usual practice to help reader with understanding
>>>code on the first glance.
>>>
>>
>> Since I have mentioned "msecs" in comment above describing the
>STREAM_TIMEOUT,
>> thought it would suffice. But if you feel I should change it, I  will fix it in v2
>
>But you didn't put that comment before each occurrence of this
>constant in the code, right?
>That's what I'm talking about. If reader looks into the code, there is
>no need to understand the order of the value for timeout, since units
>are part of the name.
>
>Of course, you may ignore this comment.
>

I agree with your comments , will wait for other comments on this patch
series and address them altogether in v2

Thanks,
Anurag Kumar Vulisha
>--
>With Best Regards,
>Andy Shevchenko