linux-kernel - [PATCH 3/3] userfaultfd: selftest: Report XFAIL if shmem doesn't support zeropage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Jul 2018 23:42:09 -0300
From:   Thiago Jung Bauermann <bauerman@...ux.ibm.com>
To:     linux-kselftest@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Prakash Sangappa <prakash.sangappa@...cle.com>,
        Thiago Jung Bauermann <bauerman@...ux.ibm.com>
Subject: [PATCH 3/3] userfaultfd: selftest: Report XFAIL if shmem doesn't support zeropage

If userfaultfd runs on a system that doesn't support UFFDIO_ZEROPAGE for
shared memory, it currently ends with error code 1 which indicates test
failure:

  # ./userfaultfd shmem 10 10
  nr_pages: 160, nr_pages_per_cpu: 80
  bounces: 9, mode: rnd poll, unexpected missing ioctl for anon memory
  # echo $?
  1

This is a real failure, but expected so signal that to the test harness:

  # ./userfaultfd shmem 10 10
  nr_pages: 160, nr_pages_per_cpu: 80
  bounces: 9, mode: rnd poll, UFFDIO_ZEROPAGE unsupported in shmem VMAs
  # echo $?
  2

Signed-off-by: Thiago Jung Bauermann <bauerman@...ux.ibm.com>
---
 tools/testing/selftests/vm/userfaultfd.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
index bc9ec38fbc34..686fe96f617f 100644
--- a/tools/testing/selftests/vm/userfaultfd.c
+++ b/tools/testing/selftests/vm/userfaultfd.c
@@ -1115,6 +1115,14 @@ static int userfaultfd_stress(void)
 		expected_ioctls = uffd_test_ops->expected_ioctls;
 		if ((uffdio_register.ioctls & expected_ioctls) !=
 		    expected_ioctls) {
+			if (test_type == TEST_SHMEM &&
+			    (uffdio_register.ioctls & expected_ioctls) ==
+			    UFFD_API_RANGE_IOCTLS_BASIC) {
+				fprintf(stderr,
+					"UFFDIO_ZEROPAGE unsupported in shmem VMAs\n");
+				return KSFT_XFAIL;
+			}
+
 			fprintf(stderr,
 				"unexpected missing ioctl for anon memory\n");
 			return 1;