linux-kernel - Re: [PATCH] net: ethernet: fs-enet: Use generic CRC32 implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180725.134211.849330522483481967.davem@davemloft.net>
Date:   Wed, 25 Jul 2018 13:42:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     krzk@...nel.org
Cc:     pantelis.antoniou@...il.com, linuxppc-dev@...ts.ozlabs.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        ebiggers3@...il.com
Subject: Re: [PATCH] net: ethernet: fs-enet: Use generic CRC32
 implementation

From: Krzysztof Kozlowski <krzk@...nel.org>
Date: Mon, 23 Jul 2018 18:20:20 +0200

> Use generic kernel CRC32 implementation because it:
> 1. Should be faster (uses lookup tables),
> 2. Removes duplicated CRC generation code,
> 3. Uses well-proven algorithm instead of coding it one more time.
> 
> Suggested-by: Eric Biggers <ebiggers3@...il.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Applied.