linux-kernel - Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180725.223427.566027515457701460.davem@davemloft.net>
Date:   Wed, 25 Jul 2018 22:34:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     anders.roxell@...aro.org
Cc:     santosh.shilimkar@...cle.com, ka-cheong.poon@...cle.com,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        rds-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/rds/Kconfig: RDS should depend on IPV6

From: Anders Roxell <anders.roxell@...aro.org>
Date: Thu, 26 Jul 2018 00:20:08 +0200

> Build error, implicit declaration of function __inet6_ehashfn shows up
> When RDS is enabled but not IPV6.
> net/rds/connection.c: In function ‘rds_conn_bucket’:
> net/rds/connection.c:67:9: error: implicit declaration of function ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’? [-Werror=implicit-function-declaration]
>   hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
>          ^~~~~~~~~~~~~~~
>          __inet_ehashfn
> 
> Current code adds IPV6 as a depends on in config RDS.
> 
> Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr")
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>

Applied.