linux-kernel - Re: [PATCH v4 14/35] mtd: rawnand: mtk: convert driver to nand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180726081402.1fa86ec5@bbrezillon>
Date:   Thu, 26 Jul 2018 08:14:02 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     xiaolei li <xiaolei.li@...iatek.com>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Wenyou Yang <wenyou.yang@...rochip.com>,
        Josh Wu <rainyfeeling@...look.com>,
        "Tudor Ambarus" <Tudor.Ambarus@...rochip.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        "Nicolas Ferre" <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Kamal Dasu <kdasu.kdev@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Han Xu <han.xu@....com>,
        Harvey Hunt <harveyhuntnexus@...il.com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Sylvain Lemieux <slemieux.tyco@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Marc Gonzalez <marc.w.gonzalez@...e.fr>,
        "Mans Rullgard" <mans@...sr.com>, Stefan Agner <stefan@...er.ch>,
        <linux-mtd@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <bcm-kernel-feedback-list@...adcom.com>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v4 14/35] mtd: rawnand: mtk: convert driver to
 nand_scan()

On Thu, 26 Jul 2018 14:06:41 +0800
xiaolei li <xiaolei.li@...iatek.com> wrote:

> On Sat, 2018-07-21 at 19:10 +0200, Boris Brezillon wrote:
> > On Fri, 20 Jul 2018 17:15:06 +0200
> > Miquel Raynal <miquel.raynal@...tlin.com> wrote:
> >   
> > > Two helpers have been added to the core to make ECC-related
> > > configuration between the detection phase and the final NAND scan. Use
> > > these hooks and convert the driver to just use nand_scan() instead of
> > > both nand_scan_ident() and nand_scan_tail().
> > > 
> > > Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> > > ---
> > >  drivers/mtd/nand/raw/mtk_nand.c | 75 ++++++++++++++++++++++++-----------------
> > >  1 file changed, 44 insertions(+), 31 deletions(-)
> > > 
> > > diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c
> > > index 7bc6be3f6ec0..967418f945ea 100644
> > > --- a/drivers/mtd/nand/raw/mtk_nand.c
> > > +++ b/drivers/mtd/nand/raw/mtk_nand.c
> > > @@ -1250,13 +1250,54 @@ static int mtk_nfc_ecc_init(struct device *dev, struct mtd_info *mtd)
> > >  	return 0;
> > >  }
> > >  
> > > +static int mtk_nfc_attach_chip(struct nand_chip *chip)
> > > +{
> > > +	struct mtd_info *mtd = nand_to_mtd(chip);
> > > +	struct device *dev = mtd->dev.parent;
> > > +	struct mtk_nfc *nfc = nand_get_controller_data(chip);
> > > +	struct mtk_nfc_nand_chip *mtk_nand = to_mtk_nand(chip);
> > > +	int len;
> > > +	int ret;
> > > +
> > > +	if (chip->options & NAND_BUSWIDTH_16) {
> > > +		dev_err(dev, "16bits buswidth not supported");
> > > +		return -EINVAL;
> > > +	}
> > > +
> > > +	/* store bbt magic in page, cause OOB is not protected */
> > > +	if (chip->bbt_options & NAND_BBT_USE_FLASH)
> > > +		chip->bbt_options |= NAND_BBT_NO_OOB;
> > > +
> > > +	ret = mtk_nfc_ecc_init(dev, mtd);
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	ret = mtk_nfc_set_spare_per_sector(&mtk_nand->spare_per_sector, mtd);
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	mtk_nfc_set_fdm(&mtk_nand->fdm, mtd);
> > > +	mtk_nfc_set_bad_mark_ctl(&mtk_nand->bad_mark, mtd);
> > > +
> > > +	len = mtd->writesize + mtd->oobsize;
> > > +	nfc->buffer = devm_kzalloc(dev, len, GFP_KERNEL);
> > > +	if (!nfc->buffer)
> > > +		return  -ENOMEM;
> > > +
> > > +	return 0;
> > > +}
> > > +
> > > +static const struct nand_controller_ops mtk_nfc_controller_ops = {
> > > +	.attach_chip = mtk_nfc_attach_chip,
> > > +};
> > > +
> > >  static int mtk_nfc_nand_chip_init(struct device *dev, struct mtk_nfc *nfc,
> > >  				  struct device_node *np)
> > >  {
> > >  	struct mtk_nfc_nand_chip *chip;
> > >  	struct nand_chip *nand;
> > >  	struct mtd_info *mtd;
> > > -	int nsels, len;
> > > +	int nsels;
> > >  	u32 tmp;
> > >  	int ret;
> > >  	int i;
> > > @@ -1287,6 +1328,7 @@ static int mtk_nfc_nand_chip_init(struct device *dev, struct mtk_nfc *nfc,
> > >  
> > >  	nand = &chip->nand;
> > >  	nand->controller = &nfc->controller;
> > > +	nand->controller->ops = &mtk_nfc_controller_ops;  
> > 
> > Just like for the marvell driver, this assignment should be moved here
> > [1].   
> Agree to this.
> 
> > Also, it looks like this driver is open-coding
> > nand_controller_init(), probably something we should fix (in a separate
> > patch).  
> May I ask if you mean driver should use nand_hw_control_init helper to
> do controller_init?

Well, now it's named nand_controller_init(), but yes, that's what I
meant.