linux-kernel - Re: [PATCH] mm/vmscan: fix page_freeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201807261459282984111@zte.com.cn>
Date:   Thu, 26 Jul 2018 14:59:28 +0800 (CST)
From:   <jiang.biao2@....com.cn>
To:     <mhocko@...nel.org>
Cc:     <akpm@...ux-foundation.org>, <hannes@...xchg.org>,
        <hillf.zj@...baba-inc.com>, <minchan@...nel.org>,
        <ying.huang@...el.com>, <mgorman@...hsingularity.net>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        <zhong.weidong@....com.cn>
Subject: Re: [PATCH] mm/vmscan: fix page_freeze_refs in comment.

Hi,
> On Thu 26-07-18 07:34:17, Jiang Biao wrote:
>> page_freeze_refs has already been relplaced by page_ref_freeze, but
>> it is not modified in the comment.
> 
> Hmm
> $ git grep page_refs_freeze origin/master
> $
> 
> The same is the case in the linux-next tree. Which tree are you looking at?
I'm sorry, it should be *page_ref_freeze*, I misspelled the word.  
And I checked  again with git grep, found there are other places with the same
problem.
# git grep page_freeze_refs master
master:mm/ksm.c:         * however, it might mean that the page is under page_freeze_refs().
master:mm/memory-failure.c:      * that may make page_freeze_refs()/page_unfreeze_refs() mismatch.
master:mm/vmscan.c:     /* note: atomic_cmpxchg in page_freeze_refs provides the smp_rmb */

I'll send v2 to fix all of these.
Thanks.

Jiang,
Regards