linux-kernel - Re: [PATCH] [RESEND] amdgpu: kfd: use modern ktime accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf114SALuHsHmhbNxG+OMh+Zg+wnfJ6mirMuu2zmXiq6fqQ@mail.gmail.com>
Date:   Thu, 26 Jul 2018 16:59:06 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        "Kuehling, Felix" <Felix.Kuehling@....com>,
        Yong Zhao <yong.zhao@....com>,
        Kent Russell <kent.russell@....com>,
        Philip Yang <Philip.Yang@....com>,
        Harish Kasiviswanathan <Harish.Kasiviswanathan@....com>,
        Andres Rodriguez <andres.rodriguez@....com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [RESEND] amdgpu: kfd: use modern ktime accessors

On Wed, Jul 11, 2018 at 3:41 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> getrawmonotonic64() and get_monotonic_boottime64() are deprecated
> because of the nonstandard naming.
>
> The replacement functions ktime_get_raw_ns() and ktime_get_boot_ns()
> also simplify the callers.
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@....com>.
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> Patch was originall sent on Jun 18 but not applied yet, resending
> With Felix' Reviewed-by tag
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index f64c5551cdba..7e717716b90e 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -754,7 +754,6 @@ static int kfd_ioctl_get_clock_counters(struct file *filep,
>  {
>         struct kfd_ioctl_get_clock_counters_args *args = data;
>         struct kfd_dev *dev;
> -       struct timespec64 time;
>
>         dev = kfd_device_by_id(args->gpu_id);
>         if (dev)
> @@ -766,11 +765,8 @@ static int kfd_ioctl_get_clock_counters(struct file *filep,
>                 args->gpu_clock_counter = 0;
>
>         /* No access to rdtsc. Using raw monotonic time */
> -       getrawmonotonic64(&time);
> -       args->cpu_clock_counter = (uint64_t)timespec64_to_ns(&time);
> -
> -       get_monotonic_boottime64(&time);
> -       args->system_clock_counter = (uint64_t)timespec64_to_ns(&time);
> +       args->cpu_clock_counter = ktime_get_raw_ns();
> +       args->system_clock_counter = ktime_get_boot_ns();
>
>         /* Since the counter is in nano-seconds we use 1GHz frequency */
>         args->system_clock_freq = 1000000000;
> --
> 2.9.0
>
Applied to -next
Thanks,
Oded