linux-kernel - Re: [PATCH] serial: core: stop passing NULL in uart_resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeuCQ+R-rK+sYbZM_ED4R5aXSXy_QiAOPd4wE7FmBxX2Q@mail.gmail.com>
Date:   Thu, 26 Jul 2018 17:04:45 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Chen Hu <hu1.chen@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: core: stop passing NULL in uart_resume_port

On Thu, Jul 26, 2018 at 12:36 PM, Chen Hu <hu1.chen@...el.com> wrote:
> Is it better to modify the DesignWare 8250 driver directly? Or do you think is this really an issue?

I have checked all of the users of do_termios in 8250 and only DW
bails out on old == NULL.

So, send a patch against 8250_dw with detailed explanation why it's
wrong (use case, examples of wrong output, etc) and how you fix it.
Describe any potential side effects (b/c it's a new behaviour).


-- 
With Best Regards,
Andy Shevchenko