linux-kernel - Re: [PATCH] mips: configs: remove no longer needed config option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180726175100.br5uk2z4aryfx64q@pburton-laptop>
Date:   Thu, 26 Jul 2018 10:51:00 -0700
From:   Paul Burton <paul.burton@...s.com>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     ralf@...ux-mips.org, jhogan@...nel.org, linux-mips@...ux-mips.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mips: configs: remove no longer needed config option

Hi Anders,

On Thu, Jul 26, 2018 at 09:04:57AM +0200, Anders Roxell wrote:
> > Since commit eedf265aa003 ("devpts: Make each mount of devpts an
> > independent filesystem.") CONFIG_DEVPTS_MULTIPLE_INSTANCES isn't needed
> > in the defconfig anymore.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> > ---
> >  arch/mips/configs/ip27_defconfig    | 1 -
> >  arch/mips/configs/nlm_xlp_defconfig | 1 -
> >  arch/mips/configs/nlm_xlr_defconfig | 1 -
> >  3 files changed, 3 deletions(-)
> 
> Ping.

Apologies - this was forgotten because it stopped showing up as
requiring action in patchwork after Ralf marked it as accepted, but it
has never been applied to the shared mips-next branch.

I do question whether it's worthwhile making these one-line changes to
configs, because:

  1) The no presence of CONFIG_DEVPTS_MULTIPLE_INSTANCES is harmless
     anyway, it'll just be ignored.

  2) The configs in question will still not be up to date with a lot of
     other changes since they were added.

Together these 2 things lead me to think that we'd be better to either:

  a) Leave the defconfigs as-is, since the changes won't make them work
     any better or worse.

  b) Regenerate them entirely, such that they're up to date with not
     just this Kconfig change but all of them.

Thanks,
    Paul