[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180726191556.GB10288@techadventures.net>
Date: Thu, 26 Jul 2018 21:15:56 +0200
From: Oscar Salvador <osalvador@...hadventures.net>
To: Pavel Tatashin <pasha.tatashin@...cle.com>
Cc: mhocko@...nel.org, Andrew Morton <akpm@...ux-foundation.org>,
Vlastimil Babka <vbabka@...e.cz>, mgorman@...hsingularity.net,
aaron.lu@...el.com, iamjoonsoo.kim@....com,
Linux Memory Management List <linux-mm@...ck.org>,
LKML <linux-kernel@...r.kernel.org>, dan.j.williams@...el.com,
osalvador@...e.de
Subject: Re: [PATCH v3 2/5] mm: access zone->node via zone_to_nid() and
zone_set_nid()
On Thu, Jul 26, 2018 at 01:55:34PM -0400, Pavel Tatashin wrote:
> On Thu, Jul 26, 2018 at 1:52 PM Michal Hocko <mhocko@...nel.org> wrote:
> >
> > On Thu 26-07-18 13:18:46, Pavel Tatashin wrote:
> > > > > OpenGrok was used to find places where zone->node is accessed. A public one
> > > > > is available here: http://src.illumos.org/source/
> > > >
> > > > I assume that tool uses some pattern matching or similar so steps to use
> > > > the tool to get your results would be more helpful. This is basically
> > > > the same thing as coccinelle generated patches.
> > >
> > > OpenGrok is very easy to use, it is source browser, similar to cscope
> > > except obviously you can't edit the browsed code. I could have used
> > > cscope just as well here.
> >
> > OK, then I misunderstood. I thought it was some kind of c aware grep
> > that found all the usage for you. If this is cscope like then it is not
> > worth mentioning in the changelog.
>
> That's what I thought :) Oscar, will you remove the comment about
> opengrok, or should I paste a new patch?
No worries, I will remove the comment ;-).
Thanks
--
Oscar Salvador
SUSE L3
Powered by blists - more mailing lists