[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20180726200730.18290-3-dianders@chromium.org>
Date: Thu, 26 Jul 2018 13:07:28 -0700
From: Douglas Anderson <dianders@...omium.org>
To: balbi@...nel.org, hminas@...opsys.com, gregkh@...uxfoundation.org
Cc: stefan.wahren@...e.com, grigor.tovmasyan@...opsys.com,
Bruno Herrera <bruherrera@...il.com>,
Zhangfei Gao <zhangfei.gao@...aro.org>, john.stultz@...aro.org,
Stephen Warren <swarren@...dotorg.org>,
Jerome Brunet <jbrunet@...libre.com>,
Douglas Anderson <dianders@...omium.org>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [REPOST PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms
There's no reason to have the uframe scheduler off on dwc2. Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".
The uframe scheduler has been off on HiSilicon since commit
37dd9d65cc41 ("usb: dwc2: add support of hi6220"). Since then there
have been many many improvements, notably the commit 9f9f09b048f5
("usb: dwc2: host: Totally redo the microframe scheduler")
Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.
Signed-off-by: Douglas Anderson <dianders@...omium.org>
Tested-by: John Stultz <john.stultz@...aro.org>
---
drivers/usb/dwc2/params.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 14b8742e62fa..db97bb16ecc4 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -67,7 +67,6 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
p->reload_ctl = false;
p->ahbcfg = GAHBCFG_HBSTLEN_INCR16 <<
GAHBCFG_HBSTLEN_SHIFT;
- p->uframe_sched = false;
p->change_speed_quirk = true;
p->power_down = false;
}
--
2.18.0.345.g5c9ce644c3-goog
Powered by blists - more mailing lists