linux-kernel - Re: [PATCH] [PATCH] mm: disable preemption before swapcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20180726151118.db0cf8016e79bed849e549f9@linux-foundation.org>
Date:   Thu, 26 Jul 2018 15:11:18 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     "zhaowuyun@...gtech.com" <zhaowuyun@...gtech.com>
Cc:     "Michal Hocko" <mhocko@...nel.org>,
        mgorman <mgorman@...hsingularity.net>,
        minchan <minchan@...nel.org>, vinmenon <vinmenon@...eaurora.org>,
        hannes <hannes@...xchg.org>,
        "hillf.zj" <hillf.zj@...baba-inc.com>,
        linux-mm <linux-mm@...ck.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "Hugh Dickins" <hughd@...gle.com>
Subject: Re: [PATCH] [PATCH] mm: disable preemption before swapcache_free

On Thu, 26 Jul 2018 15:03:23 +0800 "zhaowuyun@...gtech.com" <zhaowuyun@...gtech.com> wrote:

> >On Thu 26-07-18 10:21:40, zhaowuyun@...gtech.com wrote:
> >[...]
> >> Our project really needs a fix to this issue
> >
> >Could you be more specific why? My understanding is that RT tasks
> >usually have all the memory mlocked otherwise all the real time
> >expectations are gone already.
> >--
> >Michal Hocko
> >SUSE Labs 
> 
> 
> The RT thread is created by a process with normal priority, and the process was sleep, 
> then some task needs the RT thread to do something, so the process create this thread, and set it to RT policy.
> I think that is the reason why RT task would read the swap.

A simpler bandaid might be to replace the cond_resched() with msleep(1).