linux-kernel - Re: [PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180727193333.GA23266@redhat.com>
Date:   Fri, 27 Jul 2018 15:33:33 -0400
From:   Mike Snitzer <snitzer@...hat.com>
To:     Huaisheng Ye <yehs2007@...o.com>
Cc:     linux-nvdimm@...ts.01.org, dan.j.williams@...el.com,
        axboe@...nel.dk, linux-s390@...r.kernel.org, dave.jiang@...el.com,
        martin.petersen@...cle.com, vishal.l.verma@...el.com,
        chengnt@...ovo.com, linux-fsdevel@...r.kernel.org,
        heiko.carstens@...ibm.com, linux-kernel@...r.kernel.org,
        willy@...radead.org, colyli@...e.de, bart.vanassche@....com,
        dm-devel@...hat.com, viro@...iv.linux.org.uk,
        gregkh@...uxfoundation.org, schwidefsky@...ibm.com, jack@...e.cz,
        ross.zwisler@...ux.intel.com, agk@...hat.com,
        Huaisheng Ye <yehs1@...ovo.com>
Subject: Re: [PATCH v2 5/6] md/dm-writecache: Don't request pointer
 dummy_addr when not required

On Wed, Jul 25 2018 at 12:28pm -0400,
Huaisheng Ye <yehs2007@...o.com> wrote:

> From: Huaisheng Ye <yehs1@...ovo.com>
> 
> Function persistent_memory_claim doesn't need to get local pointer
> dummy_addr from direct_access. Using NULL instead of having to pass
> in a useless local pointer that caller then just throw away.
> 
> Suggested-by: Ross Zwisler <ross.zwisler@...ux.intel.com>
> Signed-off-by: Huaisheng Ye <yehs1@...ovo.com>

Acked-by: Mike Snitzer <snitzer@...hat.com>