linux-kernel - Re: [PATCH v3 2/2] leds: add Panasonic AN30259A support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <341157fb-257d-8984-c8d3-0e4a51c4479e@gmail.com>
Date:   Fri, 27 Jul 2018 22:22:36 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Simon Shields <simon@...eageos.org>, linux-leds@...r.kernel.org
Cc:     Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] leds: add Panasonic AN30259A support

On 07/27/2018 10:08 PM, Jacek Anaszewski wrote:
> Hi Simon,
> 
> Thank you for the updated patch. It looks good in general, with
> one reservation, please refer below.

And one more issue:

drivers/leds/leds-an30259a.c: In function 'an30259a_blink_set':
drivers/leds/leds-an30259a.c:129:23: warning: unused variable 'duty' 
[-Wunused-variable]
   unsigned int led_on, duty;
                        ^
BTW, this patch set version should be v4, so please set the next
one to v5.

-- 
Best regards,
Jacek Anaszewski