linux-kernel - Re: [PATCH] net: hisilicon: hns: Replace mdelay() with msleep()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180727.141216.2218815863913834329.davem@davemloft.net>
Date:   Fri, 27 Jul 2018 14:12:16 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baijiaju1990@...il.com
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        linyunsheng@...wei.com, joe@...ches.com, pombredanne@...b.com,
        bianpan2016@....com, shenjian15@...wei.com, keescook@...omium.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hisilicon: hns: Replace mdelay() with msleep()

From: Jia-Ju Bai <baijiaju1990@...il.com>
Date: Fri, 27 Jul 2018 16:01:41 +0800

> hns_ppe_common_init_hw() and hns_xgmac_init() are never 
> called in atomic context.
> They call mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Applied.