linux-kernel - Re: [PATCH] x86/mce: Handle varying MCA bank counts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180727220833.GA30752@agluck-desk>
Date:   Fri, 27 Jul 2018 15:08:34 -0700
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Yazen Ghannam <Yazen.Ghannam@....com>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        bp@...e.de, x86@...nel.org
Subject: Re: [PATCH] x86/mce: Handle varying MCA bank counts

On Fri, Jul 27, 2018 at 04:40:09PM -0500, Yazen Ghannam wrote:
> -	/* Don't support asymmetric configurations today */
> -	WARN_ON(mca_cfg.banks != 0 && b != mca_cfg.banks);
> -	mca_cfg.banks = b;
> +	mca_cfg.banks = max(mca_cfg.banks, b);

Should we change mca_cfg.banks to be a per-cpu variable?

	DEFINE_PER_CPU(int, mce_num_banks);

That would make it easier to make sure the places
that scan all banks only look at the ones that exist.

-Tony