linux-kernel - Re: [PATCH 03/10] atmel: hide unused procfs helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87va91vxnr.fsf@codeaurora.org>
Date:   Fri, 27 Jul 2018 12:24:40 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <simon@...kelleys.org.uk>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
        <davem@...emloft.net>, <rdunlap@...radead.org>
Subject: Re: [PATCH 03/10] atmel: hide unused procfs helpers

(fixing top posting)

YueHaibing <yuehaibing@...wei.com> writes:

> On 2018/7/13 14:46, YueHaibing wrote:
>> When CONFIG_PROC_FS isn't set, gcc warning this:
>> 
>> drivers/net/wireless/atmel/atmel.c:1402:12: warning: ‘atmel_proc_show’ defined but not used [-Wunused-function]
>>  static int atmel_proc_show(struct seq_file *m, void *v)
>>             ^
>> fix this by adding #ifdef around it.
>> 
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>
> pls ignore this,my bad.

Why should I drop this? Does the patch have something wrong which I'm
missing?

I'm asking because I prefer this over Randy's version:

https://patchwork.kernel.org/patch/10512913/

-- 
Kalle Valo