linux-kernel - Re: [PATCH] sound: usb: quirks: Replace mdelay() with msleep() and usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hzhydxb4j.wl-tiwai@suse.de>
Date:   Fri, 27 Jul 2018 11:48:28 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Jia-Ju Bai" <baijiaju1990@...il.com>
Cc:     <kai.heng.feng@...onical.com>, <nob77413@...il.com>,
        <ruslan.bilovol@...il.com>, <perex@...ex.cz>,
        <jussi@...arnerd.net>, <elfring@...rs.sourceforge.net>,
        <daniel@...que.org>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sound: usb: quirks: Replace mdelay() with msleep() and usleep_range()

On Fri, 27 Jul 2018 10:55:28 +0200,
Jia-Ju Bai wrote:
> 
> snd_usb_select_mode_quirk(), snd_usb_set_interface_quirk() and 
> snd_usb_ctl_msg_quirk() are never called in atomic context.
> They call mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep() and usleep_range().
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Applied, thanks.


Takashi