linux-kernel - Re: [PATCH] sound: pci: cthw20k2: Replace mdelay() with msleep() and usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hwothxb21.wl-tiwai@suse.de>
Date:   Fri, 27 Jul 2018 11:49:58 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Jia-Ju Bai" <baijiaju1990@...il.com>
Cc:     <bhumirks@...il.com>, <perex@...ex.cz>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sound: pci: cthw20k2: Replace mdelay() with msleep() and usleep_range()

On Fri, 27 Jul 2018 11:01:43 +0200,
Jia-Ju Bai wrote:
> 
> hw_pll_init(), hw_dac_stop(), hw_dac_start() and hw_adc_init() 
> are never called in atomic context.
> They call mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Applied, thanks.


Takashi