linux-kernel - Re: [PATCH 3/3] iommu/arm-smmu: Error out only if not enough context interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFp+6iEwS1xHYz2eptO1p2hzw+cb6WOvohDkx1SGmthzV0SbyA@mail.gmail.com>
Date:   Fri, 27 Jul 2018 15:27:33 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Will Deacon <will.deacon@....com>
Cc:     Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        David Brown <david.brown@...aro.org>,
        "list@....net:IOMMU DRIVERS <iommu@...ts.linux-foundation.org>, Joerg
        Roedel <joro@...tes.org>," <iommu@...ts.linux-foundation.org>,
        "robh+dt" <robh+dt@...nel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Andy Gross <andy.gross@...aro.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 3/3] iommu/arm-smmu: Error out only if not enough context interrupts

On Wed, Jul 25, 2018 at 5:27 PM, Will Deacon <will.deacon@....com> wrote:
> On Tue, Jul 24, 2018 at 03:09:41PM +0530, Vivek Gautam wrote:
>> On 7/24/2018 2:06 PM, Will Deacon wrote:
>> >On Thu, Jul 19, 2018 at 11:23:56PM +0530, Vivek Gautam wrote:
>> >>diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
>> >>index 7c69736a30f8..4cb53bf4f423 100644
>> >>--- a/drivers/iommu/arm-smmu.c
>> >>+++ b/drivers/iommu/arm-smmu.c
>> >>@@ -2229,12 +2229,19 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
>> >>    if (err)
>> >>            return err;
>> >>-   if (smmu->version == ARM_SMMU_V2 &&
>> >>-       smmu->num_context_banks != smmu->num_context_irqs) {
>> >>-           dev_err(dev,
>> >>-                   "found only %d context interrupt(s) but %d required\n",
>> >>-                   smmu->num_context_irqs, smmu->num_context_banks);
>> >>-           return -ENODEV;
>> >>+   if (smmu->version == ARM_SMMU_V2) {
>> >>+           if (smmu->num_context_banks > smmu->num_context_irqs) {
>> >>+                   dev_err(dev,
>> >>+                         "found only %d context irq(s) but %d required\n",
>> >>+                         smmu->num_context_irqs, smmu->num_context_banks);
>> >>+                   return -ENODEV;
>> >>+           } else if (smmu->num_context_banks < smmu->num_context_irqs) {
>> >>+                   /* loose extra context interrupts */
>> >>+                   dev_notice(dev,
>> >>+                         "found %d context irq(s) but only %d required\n",
>> >>+                         smmu->num_context_irqs, smmu->num_context_banks);
>> >>+                   smmu->num_context_irqs = smmu->num_context_banks;
>> >>+           }
>> >I don't see the utility in the new message. Can you simplify with the patch
>> >below on top? It's a bit weird that we only decide to ignore the extra irqs
>> >after calling platform_get_irq() on them, but that seems to be harmless.
>>
>> Thanks. I will modify as suggested below and respin.
>
> It's ok, I can make the change locally.

Thanks Will for making the changes, and picking this.

Best regards
Vivek

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation