linux-kernel - Re: [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Jul 2018 11:00:07 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     Douglas Anderson <dianders@...omium.org>,
        "balbi@...nel.org" <balbi@...nel.org>,
        "Minas.Harutyunyan@...opsys.com" <Minas.Harutyunyan@...opsys.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "stefan.wahren@...e.com" <stefan.wahren@...e.com>,
        "grigor.tovmasyan@...opsys.com" <grigor.tovmasyan@...opsys.com>,
        "Bruno Herrera" <bruherrera@...il.com>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        "john.stultz@...aro.org" <john.stultz@...aro.org>,
        Stephen Warren <swarren@...dotorg.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> While looking at a dwc2 recently, I noticed that some platforms still
> have the uframe scheduler off.  As far as I know, nothing good can
> come out of having the uframe scheduler off.  Let's turn it on
> everywhere.  Assuming this all works out then some time in the future
> we can gut all the old code that handles the old non-uframe scheduler
> and make everything simpler.
> 
> This is a repost of the original "RFT" (request for testing) series I
> posted a few weeks ago but without the "RFT" prefix.  Two of the
> patches in the series now have "Tested-by:" tags.  Since there should
> be nothing platform specific about the uFrame scheduler presumably
> this should mean we're good to go?  Specificaly note that in at least
> one of the "Tested-by" reports this patch caused a notable
> improvement.
> 
> In response to the original RFT, some notes about testing this:
> - In general, try to have lots of things plugged in.
> - Plug many different keyboards / mice in.  See if keys are
>    dropped / mouse is jerky.
> - Try USB audio (ideally full speed, not high speed).  How is
>    the audio?
> - If you're brave, try a USB webcam.  How is the video?
>    ...maybe try including patches from crbug.com/820961 too.
> 
> 
> Douglas Anderson (4):
>    usb: dwc2: Turn on uframe_sched on "bcm" platforms
>    usb: dwc2: Turn on uframe_sched on "his" platforms
>    usb: dwc2: Turn on uframe_sched on "amlogic" platforms
>    usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms
> 
>   drivers/usb/dwc2/params.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
Reviewed-by: Minas Harutyunyan <hminas@...opsys.com>