linux-kernel - Re: [PATCH v2 2/3] selftest/ftrace: Move kprobe selftest function to separate compile unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180727213956.f2a5509996cac359d1c3c80a@kernel.org>
Date:   Fri, 27 Jul 2018 21:39:56 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Francis Deslauriers <francis.deslauriers@...icios.com>,
        peterz@...radead.org, mathieu.desnoyers@...icios.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] selftest/ftrace: Move kprobe selftest function
 to separate compile unit

On Thu, 26 Jul 2018 19:29:43 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu, 26 Jul 2018 14:53:55 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > From: Francis Deslauriers <francis.deslauriers@...icios.com>
> > 
> > Move selftest function to its own compile unit so it can be compiled
> > with the ftrace cflags (CC_FLAGS_FTRACE) allowing it to be probed
> > during the ftrace startup tests.
> > 
> > Signed-off-by: Francis Deslauriers <francis.deslauriers@...icios.com>
> > Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
> 
> Hi Masami,
> 
> Actually, since you are sending this as part of your patch queue, you
> need to add your Signed-off-by here and not Acked-by. That means it has
> gone through you.

Ah, I see.

> 
> I've applied the first patch already, just resend this one, where you
> add you Signed-off-by instead of Acked-by.

OK, I'll do that soon.

Thanks!

> 
> Thanks!
> 
> -- Steve
> 
> 
> > ---
> >  kernel/trace/Makefile                |    5 +++++
> >  kernel/trace/trace_kprobe.c          |   12 +-----------
> >  kernel/trace/trace_kprobe_selftest.c |   10 ++++++++++
> >  kernel/trace/trace_kprobe_selftest.h |    7 +++++++
> >  4 files changed, 23 insertions(+), 11 deletions(-)
> >  create mode 100644 kernel/trace/trace_kprobe_selftest.c
> >  create mode 100644 kernel/trace/trace_kprobe_selftest.h
> > 


-- 
Masami Hiramatsu <mhiramat@...nel.org>