linux-kernel - Re: [PATCH] rtc: sh: remove unused variable rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180727152818.GE7701@piout.net>
Date:   Fri, 27 Jul 2018 17:28:18 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     a.zummo@...ertech.it, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: sh: remove unused variable rtc_dev

On 27/07/2018 17:10:15+0200, Anders Roxell wrote:
> When building rtc-sh, rtc_dev isn't used in function __sh_rtc_periodic.
> drivers/rtc/rtc-sh.c: In function ‘__sh_rtc_periodic’:
> drivers/rtc/rtc-sh.c:146:21: warning: unused variable ‘rtc_dev’ [-Wunused-variable]
>   struct rtc_device *rtc_dev = rtc->rtc_dev;
>                      ^~~~~~~
> Remove the declaration of rtc_dev to dispose the warning.
> 
> Fixes: ec623ff014c4 ("rtc: sh: remove dead code")
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---
>  drivers/rtc/rtc-sh.c | 1 -
>  1 file changed, 1 deletion(-)
> 
Applied, thanks.

It is weird that kbuild didn't complain about it though.

-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com