linux-kernel - Re: [PATCH 00/16] clk: at91: Rework DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Jul 2018 10:03:22 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     devicetree@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 00/16] clk: at91: Rework DT bindings

Quoting Alexandre Belloni (2018-07-17 15:27:41)
> This is the promised rework of the at91 PMC clocks driver. It is mainly
> necessary to remove the DTC warnings but it also complies with the CCF
> rule that there should be one node per controller instead of one node
> per clock.
> 
> This only handles the PMC, I'm planning to also rework the SCKC bindings
> later (without breaking the DT ABI).
> 
> The series is based on top of clk-next plus at91-dt so I don't think it
> is convenient to have it this cycle. However, I would really like to
> ensure we agree on the new bindings this cycle before converting all the
> other platforms as this is a bit tedious.
> 
> The first two patches are actually fixes and may be considered for this
> cycle.
> 
> One nice note:
> at91-sama5d2_xplained.dtb goes from 29351 bytes to 22082 bytes

Patches look mostly good. Rob is happy with the bindings and so am I.

One general question is why the drivers can't be moved to real platform
drivers instead of using OF_CLK_DECLARE?