linux-kernel - Re: [PATCH] input: mouse: appletouch: Replace GFP_ATOMIC with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180727183603.GF72640@dtor-ws>
Date:   Fri, 27 Jul 2018 11:36:03 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     gustavo@...eddedor.com, arvind.yadav.cs@...il.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: mouse: appletouch: Replace GFP_ATOMIC with
 GFP_KERNEL

On Fri, Jul 27, 2018 at 10:26:18AM +0800, Jia-Ju Bai wrote:
> atp_open(), atp_recover() and atp_resume() are never 
> called in atomic context.
> They call usb_submit_urb() with GFP_ATOMIC, which is not necessary.
> GFP_ATOMIC can be replaced with GFP_KERNEL.
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Applied, thank you.

> ---
>  drivers/input/mouse/appletouch.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
> index 032d27983b6c..f593ec96c95f 100644
> --- a/drivers/input/mouse/appletouch.c
> +++ b/drivers/input/mouse/appletouch.c
> @@ -810,7 +810,7 @@ static int atp_open(struct input_dev *input)
>  {
>  	struct atp *dev = input_get_drvdata(input);
>  
> -	if (usb_submit_urb(dev->urb, GFP_ATOMIC))
> +	if (usb_submit_urb(dev->urb, GFP_KERNEL))
>  		return -EIO;
>  
>  	dev->open = true;
> @@ -976,7 +976,7 @@ static int atp_recover(struct atp *dev)
>  	if (error)
>  		return error;
>  
> -	if (dev->open && usb_submit_urb(dev->urb, GFP_ATOMIC))
> +	if (dev->open && usb_submit_urb(dev->urb, GFP_KERNEL))
>  		return -EIO;
>  
>  	return 0;
> @@ -994,7 +994,7 @@ static int atp_resume(struct usb_interface *iface)
>  {
>  	struct atp *dev = usb_get_intfdata(iface);
>  
> -	if (dev->open && usb_submit_urb(dev->urb, GFP_ATOMIC))
> +	if (dev->open && usb_submit_urb(dev->urb, GFP_KERNEL))
>  		return -EIO;
>  
>  	return 0;
> -- 
> 2.17.0
> 

-- 
Dmitry