linux-kernel - Re: [PATCH v2 2/3] tty: Make constants to be enums instead of #define in goldfish.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180728145112.GA12252@kroah.com>
Date:   Sat, 28 Jul 2018 16:51:12 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     rkir@...gle.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] tty: Make constants to be enums instead of
 #define in goldfish.c

On Tue, Jul 24, 2018 at 05:51:32PM -0700, rkir@...gle.com wrote:
> From: Roman Kiryanov <rkir@...gle.com>
> 
> enums produce better compilation errors than defines.

Yes, they can, if you use them correctly.  Which you are not doing here,
so this patch really does nothing.  Why should we take it?

confused,

greg k-h