linux-kernel - Re: [PATCH v4 00/11] macintosh: Resolve various PMU driver problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <155756b2-d3cf-e47d-2ea1-58115a4cadc5@gmail.com>
Date:   Sat, 28 Jul 2018 19:08:53 +1200
From:   Michael Schmitz <schmitzmic@...il.com>
To:     Finn Thain <fthain@...egraphics.com.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-m68k@...ts.linux-m68k.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 00/11] macintosh: Resolve various PMU driver problems

No regressions on my PowerBook G4, so for this series:

Tested-by: Michael Schmitz <schmitzmic@...il.com>

Am 02.07.2018 um 20:21 schrieb Finn Thain:
> This series of patches has the following aims.
>
> 1) Eliminate duplicated code. Linux presently has two drivers for
>    the 68HC05-based PMU devices found in Macs: via-pmu and via-pmu68k.
>    There's no value in having separate PMU drivers for each architecture.
>
> 2) Avoid further work on via-pmu68k that's not needed for via-pmu.
>
> 3) Fix some bugs in the via-pmu driver.
>
> 4) Enable the /dev/pmu and /proc/pmu/* userspace APIs on m68k Macs
>    by adopting via-pmu.
>
> 5) Improve stability on early 100-series PowerBooks by loading no PMU
>    driver at all. Neither via-pmu nor via-pmu68k supports the early
>    M50753-based PMU device found in these models.
>
> 6) Assist the out-of-tree NuBus PowerMac port to support PMU designs
>    shared with the m68k Mac port (e.g. PowerBooks 190 and 5300).
>
> This patch series has been regression tested on various PowerBooks
> (190, 520, 3400, Pismo G3) and PowerMacs (Beige G3, G5). These patches
> did not affect userland utilities. (Note that there is a userland-
> visible change to the contents of /proc/pmu/interrupts.)
>
> Changed since v1:
> 1) Added blank lines after 'break' statements in patch 10.
> 2) Improved patch description for patch 3.
> 3) Added reviewed-by tags.
> 4) Split patch 8 to make code review easier.
>
> Changed since v2:
> 1) Added reviewed-by tag.
> 2) Retained PMU_68K_V1 and PMU_68K_V2 symbols.
>
> Changed since v3:
> 1) Rebased on v4.18-rc2.
> 2) Omitted patch 10/12, since these RTC changes now conflict with mainline.
>    It will be reworked once the mainline m68k/powerpc RTC code stabilizes.
>
>
> Finn Thain (11):
>   macintosh/via-pmu: Fix section mismatch warning
>   macintosh/via-pmu: Add missing mmio accessors
>   macintosh/via-pmu: Don't clear shift register interrupt flag twice
>   macintosh/via-pmu: Enhance state machine with new 'uninitialized'
>     state
>   macintosh/via-pmu: Replace via pointer with via1 and via2 pointers
>   macintosh/via-pmu: Add support for m68k PowerBooks
>   macintosh/via-pmu: Explicitly specify CONFIG_PPC_PMAC dependencies
>   macintosh/via-pmu68k: Don't load driver on unsupported hardware
>   macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver
>   macintosh/via-pmu: Clean up interrupt statistics
>   macintosh/via-pmu: Disambiguate interrupt statistics
>
>  arch/m68k/configs/mac_defconfig   |   2 +-
>  arch/m68k/configs/multi_defconfig |   2 +-
>  arch/m68k/mac/config.c            |   2 +-
>  arch/m68k/mac/misc.c              |  54 +--
>  drivers/macintosh/Kconfig         |  19 +-
>  drivers/macintosh/Makefile        |   1 -
>  drivers/macintosh/adb.c           |   2 +-
>  drivers/macintosh/via-pmu.c       | 346 ++++++++++------
>  drivers/macintosh/via-pmu68k.c    | 850 --------------------------------------
>  include/uapi/linux/pmu.h          |   4 +-
>  10 files changed, 235 insertions(+), 1047 deletions(-)
>  delete mode 100644 drivers/macintosh/via-pmu68k.c
>