linux-kernel - Re: [TRIVIAL RFC PATCH] Kconfigs - reduce use of "depends on EXPERT"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180729202718.2fbc4592@wiggum>
Date:   Sun, 29 Jul 2018 20:27:18 +0200
From:   Michael Büsch <m@...s.ch>
To:     Joe Perches <joe@...ches.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [TRIVIAL RFC PATCH] Kconfigs - reduce use of "depends on
 EXPERT"

On Sun, 29 Jul 2018 11:16:37 -0700
Joe Perches <joe@...ches.com> wrote:

> (removing a bunch of cc's)
> 
> On Sun, 2018-07-29 at 13:42 +0200, Michael Büsch wrote:
> > On Sat, 28 Jul 2018 15:13:00 -0700
> > Joe Perches <joe@...ches.com> wrote:
> >   
> > >  config SSB_SILENT
> > > -	bool "No SSB kernel messages"
> > > -	depends on SSB && EXPERT
> > > +	bool "No SSB kernel messages" if EXPERT
> > > +	depends on SSB
> > >  	help
> > >  	  This option turns off all Sonics Silicon Backplane printks.
> > >  	  Note that you won't be able to identify problems, once  
> > 
> > 
> > What about removing this option entirely?
> > We would just have to remove it from Kconfig and from its only use in
> > drivers/ssb/ssb_private.h
> > I don't think anybody uses (or should use) this option anyway.
> > That would reduce the EXPERT dependencies by one, which is a good
> > thing. :)  
> 
> I'm fine with that, but it was originally your code from
> the first ssb commit in 2007:
> 
> 	This might only be desired for production kernels on
> 	embedded devices to reduce the kernel size.
> 
> Presumably for ddwrt and such.

Yeah, but it doesn't make sense to do this in ssb only.
And it only saves a couple of k at best.

> Removal could simplify the ssb_<foo> printk logic a bit too.
> 
> Perhaps something like the below,
> but your code, your decisions...:


This is great!
Thanks.

Reviewed-by: Michael Buesch <m@...s.ch>


-- 
Michael

Content of type "application/pgp-signature" skipped